Change function in thunk to be type rather than instance #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
reviewed
Mar 18, 2023
vchuravy
approved these changes
Mar 18, 2023
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #678 +/- ##
==========================================
- Coverage 73.42% 72.25% -1.18%
==========================================
Files 18 18
Lines 6906 6948 +42
==========================================
- Hits 5071 5020 -51
- Misses 1835 1928 +93
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
vchuravy
reviewed
Mar 19, 2023
|
|
||
| Like [`autodiff_deferred`](@ref) but will try to extend f to an annotation, if needed. | ||
| """ | ||
| @inline function autodiff_deferred(mode::CMode, f::F, args...) where {F, CMode<:Mode} |
vchuravy
reviewed
Mar 19, 2023
vchuravy
reviewed
Mar 19, 2023
vchuravy
reviewed
Mar 19, 2023
| forward = thunk(fn, dfn, Const, Tuple{}, Val(API.DEM_ForwardMode), width, Val((false,))) | ||
|
|
||
| forward = thunk(Duplicated{Core.Typeof(fn)}, Const, Tuple{}, Val(API.DEM_ForwardMode), width, Val((false,))) | ||
| ft = Duplicated(fn, dfn) |
vchuravy
reviewed
Mar 19, 2023
vchuravy
reviewed
Mar 19, 2023
vchuravy
reviewed
Mar 19, 2023
vchuravy
reviewed
Mar 19, 2023
vchuravy
approved these changes
Mar 19, 2023
Co-authored-by: Valentin Churavy <vchuravy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.