Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add blas attrs on the julia side #794

Merged
merged 5 commits into from
May 8, 2023
Merged

add blas attrs on the julia side #794

merged 5 commits into from
May 8, 2023

Conversation

ZuseZ4
Copy link
Member

@ZuseZ4 ZuseZ4 commented Apr 27, 2023

Just experimenting, doesn't fix the julia-tblgen-blas failure for some reason yet.

  • We should also set attrs per arg, not only per function.
  • Already set by blas-tblgen in the AdjointGenerator, but that's pretty late. Probably better to factor this out once it's working, so we can call it during AA and don't have to re-implement it for julia.

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2023

Codecov Report

Patch coverage: 82.35% and project coverage change: -0.37 ⚠️

Comparison is base (54c0cb6) 77.76% compared to head (a9d53e5) 77.40%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
- Coverage   77.76%   77.40%   -0.37%     
==========================================
  Files          18       18              
  Lines        7416     7434      +18     
==========================================
- Hits         5767     5754      -13     
- Misses       1649     1680      +31     
Impacted Files Coverage Δ
src/compiler.jl 77.91% <82.35%> (-0.49%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZuseZ4 ZuseZ4 marked this pull request as ready for review May 5, 2023 18:55
@ZuseZ4
Copy link
Member Author

ZuseZ4 commented May 5, 2023

@wsmoses requires an enzyme bump, but other than that it seems good to merge?

@wsmoses wsmoses merged commit e96c0c5 into main May 8, 2023
22 of 32 checks passed
@wsmoses wsmoses deleted the blas_fnc_attrs branch May 8, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants