Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better active reg #845

Merged
merged 3 commits into from
May 13, 2023
Merged

better active reg #845

merged 3 commits into from
May 13, 2023

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented May 13, 2023

Fixes #841

@wsmoses wsmoses requested a review from vchuravy May 13, 2023 20:30
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2023

Codecov Report

Patch coverage: 72.72% and project coverage change: -0.08 ⚠️

Comparison is base (69635f4) 77.96% compared to head (e8f8cb0) 77.89%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
- Coverage   77.96%   77.89%   -0.08%     
==========================================
  Files          18       18              
  Lines        8356     8404      +48     
==========================================
+ Hits         6515     6546      +31     
- Misses       1841     1858      +17     
Impacted Files Coverage Δ
src/compiler.jl 79.21% <72.72%> (-0.09%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wsmoses wsmoses merged commit ff747a9 into main May 13, 2023
24 of 32 checks passed
@wsmoses wsmoses deleted the acreg branch May 13, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: TypeAnalysisDepthLimit, incorrect gradient
2 participants