Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ubuntu 20.04 and renable assert builds #883

Merged
merged 2 commits into from
May 31, 2023
Merged

Use Ubuntu 20.04 and renable assert builds #883

merged 2 commits into from
May 31, 2023

Conversation

vchuravy
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.09 ⚠️

Comparison is base (9487eb8) 78.11% compared to head (95ab2cc) 78.03%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #883      +/-   ##
==========================================
- Coverage   78.11%   78.03%   -0.09%     
==========================================
  Files          18       18              
  Lines        8417     8417              
==========================================
- Hits         6575     6568       -7     
- Misses       1842     1849       +7     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vchuravy
Copy link
Member Author

@vchuravy
Copy link
Member Author

Assertions are green, which is nice.

@vchuravy vchuravy merged commit 8829874 into main May 31, 2023
19 of 35 checks passed
@vchuravy vchuravy deleted the vc/gh branch May 31, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants