Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow support for noinline on inner function #888

Merged
merged 1 commit into from
Jun 3, 2023
Merged

Allow support for noinline on inner function #888

merged 1 commit into from
Jun 3, 2023

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Jun 2, 2023

No description provided.

@wsmoses wsmoses requested a review from vchuravy June 2, 2023 18:29
@wsmoses
Copy link
Member Author

wsmoses commented Jun 2, 2023

Fixes #884

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.10 ⚠️

Comparison is base (8829874) 78.11% compared to head (5daa61a) 77.02%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #888      +/-   ##
==========================================
- Coverage   78.11%   77.02%   -1.10%     
==========================================
  Files          18       18              
  Lines        8417     8400      -17     
==========================================
- Hits         6575     6470     -105     
- Misses       1842     1930      +88     
Impacted Files Coverage Δ
src/compiler.jl 79.45% <100.00%> (-0.04%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wsmoses wsmoses merged commit 699f9a7 into main Jun 3, 2023
19 of 35 checks passed
@wsmoses wsmoses deleted the noinl_inner branch June 3, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants