Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reinsert gc marker before lowering #907

Merged
merged 2 commits into from
Jun 23, 2023
Merged

reinsert gc marker before lowering #907

merged 2 commits into from
Jun 23, 2023

Conversation

wsmoses
Copy link
Member

@wsmoses wsmoses commented Jun 23, 2023

No description provided.

@wsmoses wsmoses requested a review from vchuravy June 23, 2023 17:58
@@ -1006,6 +1006,7 @@ end

function addJuliaLegalizationPasses!(pm, lower_intrinsics=true)
if lower_intrinsics
add!(pm, FunctionPass("ReinsertGCMarker", reinsert_gcmarker_pass!))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After barrier noop?

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (c348d48) 77.43% compared to head (24669bf) 77.46%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #907      +/-   ##
==========================================
+ Coverage   77.43%   77.46%   +0.02%     
==========================================
  Files          18       18              
  Lines        8404     8405       +1     
==========================================
+ Hits         6508     6511       +3     
+ Misses       1896     1894       -2     
Impacted Files Coverage Δ
src/compiler/optimize.jl 71.28% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vchuravy vchuravy merged commit f05bc0e into main Jun 23, 2023
30 of 35 checks passed
@vchuravy vchuravy deleted the gclower branch June 23, 2023 18:45
michel2323 pushed a commit that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants