ORE and better phi unwrapping #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
approved these changes
Feb 15, 2021
| @@ -116,19 +130,30 @@ Value *GradientUtils::unwrapM(Value *const val, IRBuilder<> &BuilderM, | |||
| } | |||
| } | |||
|
|
|||
| // llvm::errs() << "uwval: " << *val << "\n"; | |||
| #define getOp(v) \ | |||
| #define getOpFullest(vtmp, frominst, check) \ | |||
There was a problem hiding this comment.
Does it make sense to turn this into an inlined function instead of a macro?
There was a problem hiding this comment.
This function was apparently a major performance bottleneck, thus why it became a macro. For release builds it doesn't matter, but I presume marking as inline won't actually inline in debug builds?
There was a problem hiding this comment.
Right I forget that GCC/Clang ignores force inlining in debug mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.