Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pass to load definitions of common functions from bc files - starting with cblas_ddot #220

Merged
merged 1 commit into from Jul 10, 2021

Conversation

reikdas
Copy link
Collaborator

@reikdas reikdas commented Jun 30, 2021

No description provided.

@reikdas reikdas requested a review from wsmoses June 30, 2021 10:43
enzyme/BCLoad/BCLoader.cpp Outdated Show resolved Hide resolved
@reikdas reikdas force-pushed the reikdas/bcpass branch 3 times, most recently from 2849146 to 2f4d1cb Compare June 30, 2021 19:36
@reikdas
Copy link
Collaborator Author

reikdas commented Jul 1, 2021

@wsmoses The tests seem to be failing on LLVM versions <=9. Could it have something to do with LLVM IR generated by higher versions of Clang, not being able to be read by lower versions of LLVM/Clang?

Copy link
Member

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sure to rebase on whatever current main is before landing (and please squash the commits).

@wsmoses wsmoses merged commit 9be5033 into main Jul 10, 2021
@wsmoses wsmoses deleted the reikdas/bcpass branch July 10, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants