[TypeAnalysis] update handling of select & induct on floats #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
reviewed
Oct 13, 2020
vchuravy
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type Analysis wasn't being sufficiently aggressive to learn that floating-point phi's generated by vectorization could indeed have their types learned inductively.
This could, however, lead to compile-time blow-ups that are O(N!) in the length of a phi-node chain which are far more likely for floating points (used in results) than in integers where the inductive rule is being applied.
Practically, the performance impact of this is resolved by also upgrading the type propagation rule for a select instruction -- though this should separately be looked into to ensure reasonable compile times.