Easier Clang Integration, Type Analysis Updates, & Primitive Cuda support #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
force-pushed
the
cuda
branch
5 times, most recently
from
5135043
to
192c734
Compare
wsmoses
force-pushed
the
cuda
branch
4 times, most recently
from
1b761f2
to
2217437
Compare
wsmoses
changed the title
vchuravy
reviewed
Oct 15, 2020
| void HandleAutoDiff(CallInst *CI, TargetLibraryInfo &TLI, AAResults &AA) { | ||
| llvm::cl::opt<bool> | ||
| EnzymePostOpt("enzmye-postopt", cl::init(false), cl::Hidden, | ||
| cl::desc("Run enzymepostprocessing optimizations")); |
There was a problem hiding this comment.
Suggested change
| cl::desc("Run enzymepostprocessing optimizations")); | |
| cl::desc("Run enzyme postprocessing optimizations")); |
enzyme/Enzyme/Enzyme.cpp
Outdated
| ++i; | ||
| res = CI->getArgOperand(i); | ||
| } else if (MS == "enzyme_out") { | ||
| llvm::errs() << "saw metadata for diffe_out\n"; |
| GVN().run(*NewF, AM); | ||
| SROA().run(*NewF, AM); | ||
| #endif |
There was a problem hiding this comment.
Suggested change
| #endif | |
| #endif |
| @@ -692,18 +684,15 @@ void optimizeIntermediate(GradientUtils *gutils, bool topLevel, Function *F) { | |||
|
|
|||
| // TODO function attributes | |||
| // PostOrderFunctionAttrsPass().run(*F, AM); | |||
| #if LLVM_VERSION_MAJOR <= 7 | |||
There was a problem hiding this comment.
Suggested change
| #if LLVM_VERSION_MAJOR <= 7 | |
| #if LLVM_VERSION_MAJOR <= 7 |
| InstSimplifyPass().run(*F, AM); | ||
| #endif | ||
| CorrelatedValuePropagationPass().run(*F, AM); | ||
| #endif |
There was a problem hiding this comment.
Suggested change
| #endif | |
| #endif |
| llvm_unreachable("unhandled atomic add"); | ||
| } | ||
| } else { | ||
| #if LLVM_VERSION_MAJOR >= 9 |
There was a problem hiding this comment.
Suggested change
| #if LLVM_VERSION_MAJOR >= 9 | |
| #if LLVM_VERSION_MAJOR >= 9 |
enzyme/Enzyme/GradientUtils.h
Outdated
| #if LLVM_VERSION_MAJOR >= 9 | ||
| AtomicRMWInst::BinOp op = AtomicRMWInst::FAdd; | ||
| AtomicRMWInst* rmw = BuilderM.CreateAtomicRMW (op, ptr, dif, AtomicOrdering::Monotonic, SyncScope::System); | ||
| #if LLVM_VERSION_MAJOR >= 11 |
There was a problem hiding this comment.
Suggested change
| #if LLVM_VERSION_MAJOR >= 11 | |
| #if LLVM_VERSION_MAJOR >= 11 |
vchuravy
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a ClangEnzyme.so for loading directly into clang (necessary for ease of use with GPU backend). Introduces primitive support for PTX backend among various type and activity analysis updates. Also fixes pre and post Enzyme optimizations to work across various LLVM versions