[NF] Notch GUI #546
Merged
[NF] Notch GUI #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dding point in _comp_point_coordinate for the schematics, adding it in test_plot_schematics.py
… into Branch_Dev_B
… into Branch_Dev_B # Conflicts: # pyleecan/GUI/Dialog/DMachineSetup/DNotchTab/WNotch/WNotch.py
… into Branch_Dev_B # Conflicts: # pyleecan/GUI/Dialog/DMachineSetup/DNotchTab/WNotch/WNotch.py
…he stator of a machine
… into Branch_Dev_B
…tch on the rotor + checking that the machine is correctly saved. Fixing bug where we would load Test\Data\Material, instead loading pyleecan\Data\Material
…e of UI according to its machine (nb of notches)
…ke sure that the UI is filled out and that the notches aren't colliding with the rest of the machine (including changing the error message)
…age should appear)
…ying a QMessageBox)
…notch colliding with slot)
… the right error in test
…ght error is raised
…deleting the text inside (case where test was "")
… + closing each widget before teardown
…s set back to None to prevent from qmessagebox
…rated each time with a json
… into Branch_Dev_B
… into Branch_Dev_B
…nd WSlotCirc according to the lamination (stator ext or rotor int)
… into Branch_Dev_B
…h_Dev_B # Conflicts: # pyleecan/Classes/Class_Dict.json # pyleecan/Classes/Lamination.py # pyleecan/Classes/SlotCirc.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all,
This PR add a now group in the "Lamination" step GUI to define N notches steps.
For now only Rectangular, Circular, Polar and DXF slot shape are available but any slot GUI could be added if needed.
The notches are available on all laminations bore radius, after merging #529 and solving FEMM simulation with yoke notch, a combobox could be added into the GUI to select bore/yoke radius.
Best regards,
Pierre