Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page freeze when clicking next month #207

Closed
fsfarah opened this issue Feb 27, 2014 · 20 comments
Closed

Page freeze when clicking next month #207

fsfarah opened this issue Feb 27, 2014 · 20 comments

Comments

@fsfarah
Copy link

fsfarah commented Feb 27, 2014

Hello Eonasdan,
The current date is 27 Feb 2014, whenever I click next month the whole page freezes. Even if I click 1 March. Going backwards works fine, going forward is the issue. Has this occurred with anyone before?
Please advise.
Thanks

@fsfarah
Copy link
Author

fsfarah commented Feb 27, 2014

When I click April I get an error
Uncaught TypeError: Cannot call method 'append' of undefined
at line 378 row.append('' + prevMonth.date() + '');

Tried on Firefox and Chrome

@Eonasdan
Copy link
Owner

can you provide more code or a jsfiddle please?

@fsfarah
Copy link
Author

fsfarah commented Feb 28, 2014

I will try ASAP,in the meantime can you try the picker on your demo
website? Try navigating to march or April, your online page was also
freezing
On Feb 28, 2014 11:16 PM, "Eonasdan" notifications@github.com wrote:

can you provide more code or a jsfiddle please?

Reply to this email directly or view it on GitHubhttps://github.com//issues/207#issuecomment-36395228
.

@Eonasdan
Copy link
Owner

I've tried both Chrome and FF on the demo page I can't replicate it. :(

@fsfarah
Copy link
Author

fsfarah commented Feb 28, 2014

That is weird! :-( I'm using Windows btw if that is in any way related..
On Feb 28, 2014 11:32 PM, "Eonasdan" notifications@github.com wrote:

I've tried both Chrome and FF on the demo page I can't replicate it. :(

Reply to this email directly or view it on GitHubhttps://github.com//issues/207#issuecomment-36396586
.

@fsfarah
Copy link
Author

fsfarah commented Mar 5, 2014

Hello again, I just wanted to inform you that on my mobile using Chrome the picker works just fine. From my laptop however the page is still freezing, on my website as well as your demo page.

Regards

@Eonasdan
Copy link
Owner

Eonasdan commented Mar 5, 2014

Can you try the staging branch? I've made a bunch of updates to it.

@Eonasdan
Copy link
Owner

do you still have this issue with the latest version?

@fsfarah
Copy link
Author

fsfarah commented Mar 12, 2014

@Eonasdan
Copy link
Owner

what version of moment are you using? You should be able to download the zipped version of the gh-pages branch and try the index page and see if you still have the problem

@fsfarah
Copy link
Author

fsfarah commented Mar 12, 2014

Got a unresponsive page error in Chrome
and this in firefox
A script on this page may be busy, or it may have stopped responding. You
can stop the script now, or you can continue to see if the script will
complete.

Script: http://cdnjs.cloudflare.com/ajax/libs/jquery/2.0.3/jquery.min.js:5
Page froze on load before I did any action

On Wed, Mar 12, 2014 at 4:30 PM, Eonasdan notifications@github.com wrote:

what version of moment are you using? You should be able to download the
zipped version of the gh-pages branchhttps://github.com/Eonasdan/bootstrap-datetimepicker/tree/gh-pagesand try the index page and see if you still have the problem

Reply to this email directly or view it on GitHubhttps://github.com//issues/207#issuecomment-37414623
.

@leo-mck
Copy link

leo-mck commented Mar 28, 2014

@fsfarah are your computer adjusted to "automatically adjust clock for daylight savig time"? (see here #258)

@fsfarah
Copy link
Author

fsfarah commented Mar 28, 2014

Hello, thanks for the feedback.
Even if this works it doesn't really solve the issue, I can't ask page visitors to disable daylight saving time option.
All in all this is great news, I assume that this narrows down what needs to be fixed in the code.
Thanks.

@leo-mck
Copy link

leo-mck commented Apr 1, 2014

@fsfarah please look here: #258 (comment)

@Eonasdan
Copy link
Owner

Eonasdan commented Jul 9, 2014

I'm making #376 the primary issue and merge all these dups together, please carry on your conversation there. Do any of you still have this issue?

@Eonasdan Eonasdan closed this as completed Jul 9, 2014
@fsfarah
Copy link
Author

fsfarah commented Jul 9, 2014

Last time I checked yes, it appears when you choose any month between April
and January, were you able to replicate this issue?
On Jul 9, 2014 11:24 PM, "Eonasdan" notifications@github.com wrote:

I'm making #376
#376 the
primary issue and merge all these dups together, please carry on your
conversation there. Do any of you still have this issue?

Reply to this email directly or view it on GitHub
#207 (comment)
.

@Eonasdan
Copy link
Owner

Eonasdan commented Jul 9, 2014

nope. People keep telling me it happens but I can reproduce it.

@Eonasdan
Copy link
Owner

Eonasdan commented Aug 6, 2014

Please check the latest source in the development branch. Others are reporting this issue to be fixed

@fsfarah
Copy link
Author

fsfarah commented Aug 7, 2014

thanks for including me in the email :) I'll check it now

On Wed, Aug 6, 2014 at 10:16 PM, Eonasdan notifications@github.com wrote:

Please check the latest source in the development branch. Others are
reporting this issue to be fixed

Reply to this email directly or view it on GitHub
#207 (comment)
.

@fsfarah
Copy link
Author

fsfarah commented Aug 7, 2014

Works perfectly! It has been re-implemented.
Thanks again,
Fouad

On Thu, Aug 7, 2014 at 9:22 AM, Fouad Farah fouad@zimaradius.com wrote:

thanks for including me in the email :) I'll check it now

On Wed, Aug 6, 2014 at 10:16 PM, Eonasdan notifications@github.com
wrote:

Please check the latest source in the development branch. Others are
reporting this issue to be fixed

Reply to this email directly or view it on GitHub
#207 (comment)
.

Repository owner locked and limited conversation to collaborators Jun 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants