Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6] Clear button raises 'change.td' event before updating the related input value #2516

Closed
mvxproject opened this issue Mar 13, 2022 · 3 comments

Comments

@mvxproject
Copy link

when listening to 'change.td' event, the clear button raises the event before updating the related input value.

to reproduce: in the simple setup example:

https://stackblitz.com/edit/tempus-dominus-v6-simple-setup

we modify the JS code:

new tempusDominus.TempusDominus(document.getElementById('datetimepicker1'), {
  //put your config here
  display:
  {
    buttons:{
      clear: true
    }
  }


});

document.getElementById('datetimepicker1').addEventListener("change.td", function () {
console.log(document.getElementById('datetimepicker1Input').value);

});

the first click on the clear button shows the last selected date.
the second click shows an empty string.

Proposed resolution :

in dates.ts file, We move: updateInput(); in line 189

updateInput();

before : this._context._triggerEvent in line

this._context._triggerEvent({

Version: v6.0.0-beta2

@scidec
Copy link

scidec commented Mar 25, 2022

Similar issue for me with linked controls - Cannot convert undefined or null to object

Eonasdan added a commit that referenced this issue Apr 11, 2022
Fixed clear button event cycle. #2516
Fixed 2 digit formatting. #2513
Trigger native change event on input when available - fixes #2401 via #2533
Fixes use of SVG icons (issue #2527) via #2529
Eonasdan added a commit that referenced this issue Apr 11, 2022
Fixed clear() doesn't erase text of date. #2472
Fixed clear button event cycle. #2516
Fixed 2 digit formatting. #2513
Trigger native change event on input when available - fixes #2401 via #2533
Fixes use of SVG icons (issue #2527) via #2529
Eonasdan added a commit that referenced this issue Apr 11, 2022
Fixed clear button event cycle. #2516
Fixed 2 digit formatting. #2513
Trigger native change event on input when available - fixes #2401 via #2533
Fixes use of SVG icons (issue #2527) via #2529
@Eonasdan
Copy link
Owner

Hello. This should be fixed in beta 5

@mvxproject
Copy link
Author

Bug Fixed, Thank you,

Eonasdan added a commit that referenced this issue Apr 22, 2022
* sonarqube issues

* plugins and locales!

* sonarqube issues

* plugins and locales!

* trying out some plugin stuff

* tiny di works

* clean packagelock

* fixed docs, plugin examples, add other locales

* update build

* doc updates. moved cheese

* types

* I spel real good

* Fixed month manipulation issue #2474

* fixed start/end of week #2473

* If view option is passed do not override with default.

* dark mode and minification!

* input event trigger

* fix for disposing inline calender gives an exception


#2493

* fix reshow should not call dates.setValue with the current

fixes: #2488

when a reshow is done, especially with inline calender
the useCurrent or useDefault should not be used if there is already
someting in the dates.
If there is already a date set, but then you update some options it
should stick to that date, not reset to the current or default..

* #fixes 2424

* bit of code clean up
added view mode information to events

* code cleanup

* update paint

* sonar

* sonar

* sonar

* sonar

* sonar

* sonar

* clean up and bug fixes

* Fixes use of SVG icons (issue #2527) (#2529)

- Create SVG elements in correct namespace
- Add standard `href` tag to `use` element. Maintain deprecated `xlink:href` for backward compatibility.

See:
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/xlink:href
https://svgwg.org/svg2-draft/linking.html#XLinkRefAttrs

* Trigger native change event on input when available (#2533)

* Fixed clear() doesn't erase text of date. #2472
Fixed clear button event cycle. #2516
Fixed 2 digit formatting. #2513
Trigger native change event on input when available - fixes #2401 via #2533
Fixes use of SVG icons (issue #2527) via #2529

* Fixed clear() doesn't erase text of date. #2472
Fixed clear button event cycle. #2516
Fixed 2 digit formatting. #2513
Trigger native change event on input when available - fixes #2401 via #2533
Fixes use of SVG icons (issue #2527) via #2529

* Fix 2539; (#2541)

- Fix template for 24H HourDisplay

Co-authored-by: William Duban Hernandez Monterrosa <desarrollo2@asfsolucionessas.com>

* formatting hotfix

Co-authored-by: jorge <eznowden@gmail.com>
Co-authored-by: Johan Compagner <jcompagner@servoy.com>
Co-authored-by: Jacob Chafik <jacob.chafik@intelliworxit.com>
Co-authored-by: William <duban.hernandez23@gmail.com>
Co-authored-by: William Duban Hernandez Monterrosa <desarrollo2@asfsolucionessas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants