3.x - Widget top position is wrong #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eonasdan
added a commit
that referenced
this pull request
Jul 24, 2015
3.x - Widget top position is wrong
ksiery
added a commit
to ShortlistProject/bootstrap-datetimepicker
that referenced
this pull request
Jun 14, 2017
Repository owner
locked and limited conversation to collaborators
Jun 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in #736, there is an issue when placing widget to top position. In some cases, widget is out of screen a bottom of the page.
To reproduce, your date field has to be at the bottom of the browser (but you can still scroll bottom). Datepicker can't display under date field so should be placed at top.
Fix proposed by @tayhimself in issue #736 doesn't work perfectly. Here is a fix which works fine in my tests.