Add Transactions #166
Open
Add Transactions #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…last-master Conflicts: src/emysql_util.erl
|
I haven't tested this, but it looks pretty sweet! |
added 7 commits
July 20, 2016 08:59
- Added Erlang version check and correct type selection - Added erlang:timestamp() check script and correct compilation path for rebar and Makefile - Added macro for TIMESTAMP and replaced direct calls with macros
Moved conditional compilation into .erl files to avoid issues in projects that include emysql header.
Builds failed on Erlang prior to 17
Included patches: - howleysv@dda35e1 - howleysv@00d2f86
|
great work @larshesel ! |
|
oh - I didn't realize master of this repo was part of a PR! haha. I can't close the PR since I don't own it and I don't suppose it makes sense to have transactions / erlang 18 stuff mixed into the same PR. Sorry for hijaking the PR like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.