New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User list export: apply filters (fixes #298) #481
Conversation
resources/views/secretariat/user/list_users_component.blade.php
Outdated
Show resolved
Hide resolved
The new |
Yeah I was also thinking about that but honestly I kind of want to rewrite the whole scope to support multiple roles in an optimal way and then use the scope for the hasRole function. Whether to support object arguments or IDs is also a debatable. Objects improve readability and static typing whereas IDs are usually more optimal (if you only have the id you should be able to pass it as it is). In short, it's fine by me, but feel free to investigate it further. I'll take a look at this |
FYI you can use https://laravel.com/docs/11.x/queries#debugging to see make sure the queries are good. Or also in laravel debugbar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the docs. LGTM, if you want to merge now.
I want to merge now. |
Summary of changes:
/users
route has been replacedlist.blade.php
tolist_users_component.blade.php
users.export
route: the click is now handled within the livewire componentTo implement the filtering, aUserFilter
utility class has been createdExport
classes underUsersSheets
have been modified so that the included users can be specifiedusers.export
path (hopefully) hasn't changed: the same users will get included in the exports as beforeSmall, mostly unrelated fixes:
$show_feedback
property has been deleted fromSemesterEvaluationExport
: it was unusedUsersExport
also assumed thatSemesterEvaluationExport
had aboolean
constructor parameter, while in fact, it did not have any parameters. This has also been fixed.ListUsers
's status related methods incorrectly named their parametersstatus_id
, while in reality they received a status (string), not an ID