Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make a single assert_valid_posit_id function for accessors #822

Closed
AdrienLeGuillou opened this issue Feb 17, 2023 · 0 comments · Fixed by #901
Closed

make a single assert_valid_posit_id function for accessors #822

AdrienLeGuillou opened this issue Feb 17, 2023 · 0 comments · Fixed by #901

Comments

@AdrienLeGuillou
Copy link
Member

the posit_ids checks for accessors where made prior to UID / PID implementation.
Thus they do not check for NAs in posit IDs (created from get_unique_ids with deactivated nodes

This function could implement all checks for posit_ids and error if any of them fails (with a comprehensive message)

tests:

  • any NA
  • any PID > population size

Open question:
should we still allow posit_ids to be a logical vector? This was to mimic the vector subsetting but I am not sure it is used and it makes the code heavier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant