Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subscribe interval from listener #106

Merged
merged 2 commits into from Jan 9, 2024
Merged

Conversation

johanneshahn
Copy link
Member

Remove subscribe interval, executed by listener.
Remove unnecessary subscribe and interval code.

This fix is working only if the epixbox relay server has a reduced interval time.
If epixbox subscription interval is to high (see epicbox script "setInterval(forIntervalChallenge, 3*60*1000);"), then the listener is quitting the connection to epicbox relay server.

Copy link
Contributor

@who-biz who-biz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed working. We should reduce challenge interval in epicboxnodejs-source repo to accompany these changes. I will PR that.

@who-biz
Copy link
Contributor

who-biz commented Jan 4, 2024

I have PRed the interval reduction here: EpicCash/epicboxnodejs-source#6

Increases frequency to 60sec which should prevent most timeouts.

@who-biz who-biz merged commit 12077a2 into master Jan 9, 2024
1 check passed
@who-biz who-biz deleted the epicbox-subscribefix branch January 9, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants