Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there any way to include initial file in cargo package? #6

Closed
POPPIN-FUMI opened this issue Sep 1, 2022 · 2 comments · Fixed by #20
Closed

Is there any way to include initial file in cargo package? #6

POPPIN-FUMI opened this issue Sep 1, 2022 · 2 comments · Fixed by #20
Assignees
@JonasCir
Labels
hot

Comments

@POPPIN-FUMI
Copy link
Collaborator

zapp new downloads the initial file from Google Cloud Storage at this moment.

zapp/src/init/process.rs

Line 126 in 5d9f951

pub async fn dl_zapp(app_name: &str) {

This initial folder is just 23KB.
I want to have it in the local machine when cargo install zapp.
@JonasCir
Copy link
Collaborator

Agreed 👍 I was wondering what this function was doing.

I think we can template the rust code through quote directly. Other resources can just be formatted/printed or we find a way to include assets in cargo crates (I know there are ways, but needs investigation how to do this cleanly).

@POPPIN-FUMI
Copy link
Collaborator Author

Yeah, Awesome!
This also has a quest here;
https://alpha.epics.dev/ja/quest/UXVlc3Q6NA==/

JonasCir added a commit to JonasCir/zapp that referenced this issue Oct 5, 2022
@JonasCir
[EpicsDAO#6] generate new project instead of downloading a ZIP template
7cd4c2e
JonasCir added a commit to JonasCir/zapp that referenced this issue Oct 7, 2022
@JonasCir
[EpicsDAO#6] rewrite new module
c559fe2
JonasCir added a commit to JonasCir/zapp that referenced this issue Oct 7, 2022
@JonasCir
[EpicsDAO#6] rewrite new module
401c1a8
JonasCir added a commit to JonasCir/zapp that referenced this issue Oct 7, 2022
@JonasCir
[EpicsDAO#6] rewrite new module
922679b
JonasCir added a commit to JonasCir/zapp that referenced this issue Oct 7, 2022
@JonasCir
[EpicsDAO#6] rewrite new module
189df64
JonasCir added a commit to JonasCir/zapp that referenced this issue Oct 7, 2022
@JonasCir
[EpicsDAO#6] rewrite new module
f70f467
JonasCir added a commit to JonasCir/zapp that referenced this issue Oct 7, 2022
@JonasCir
[EpicsDAO#6] rewrite new module
05c40cc
@JonasCir JonasCir mentioned this issue Oct 7, 2022
Merged
JonasCir added a commit to JonasCir/zapp that referenced this issue Oct 7, 2022
@JonasCir
[EpicsDAO#6] add .env in templates and tests explicitly
41dcbd7
@JonasCir JonasCir self-assigned this Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JonasCir JonasCir

Labels
hot
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite the new module such that nothing needs to be downloaded JonasCir/zapp
2 participants
@JonasCir @POPPIN-FUMI