Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Epimap.fr to links #71

Merged
merged 2 commits into from Oct 2, 2021
Merged

Add Epimap.fr to links #71

merged 2 commits into from Oct 2, 2021

Conversation

NathanCHEVALIER
Copy link
Contributor

epimap informations replaced by the new version recently created

@matiboux matiboux self-assigned this Sep 26, 2021
matiboux
matiboux requested changes Sep 26, 2021
View reviewed changes
Copy link
Member

@matiboux matiboux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution! Awesome project!

I just need to fix some of the item's style properties for you.

_data/links.yml Outdated Show resolved Hide resolved
_data/links.yml Outdated Show resolved Hide resolved
_data/links.yml Outdated Show resolved Hide resolved
matiboux
matiboux requested changes Sep 26, 2021
View reviewed changes
Copy link
Member

@matiboux matiboux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing: the UX when navigating the map is not great, you should add the name of the opened map in the page top bar and page title.
I am just waiting on this UX update before continuing with the merging of this PR!

@matiboux matiboux mentioned this pull request Oct 1, 2021
Merged
@matiboux matiboux changed the title links.yml: epimap infos updated with new version Add Epimap.fr to links Oct 2, 2021
matiboux
matiboux approved these changes Oct 2, 2021
View reviewed changes
Copy link
Member

@matiboux matiboux left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required UX update pushed to epimap.fr
Thanks again for your contribution!

@matiboux matiboux merged commit e761863 into Epidocs:master Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiboux matiboux matiboux approved these changes

Assignees

@matiboux matiboux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NathanCHEVALIER @matiboux