Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 5 compatibility #33

Open
Amaca opened this issue Jan 9, 2023 · 5 comments
Open

Webpack 5 compatibility #33

Amaca opened this issue Jan 9, 2023 · 5 comments

Comments

@Amaca
Copy link
Contributor

Amaca commented Jan 9, 2023

Hello,
i think this plugin is very useful but i need to update my webpack at version 5. I was wondering if you are thinking to update the plugin to make it works on webpack 5. I hope so.

Thanks

@Epimodev
Copy link
Owner

Epimodev commented Jan 9, 2023

Hello!

Thanks for your issue, I'm happy to read this plugin could help you.

This plugin is already updated for webpack 5 since last year but I forgot to update the readme file.

You can find the merge request about upgrade here: #21

So you can use this plugin. But I don't maintain it anymore because I stopped using webpack for several years.

@Amaca
Copy link
Contributor Author

Amaca commented Jan 10, 2023

Thank you for answering so fast @Epimodev ! I read the pull request but i still have some trouble on installation:

npm ERR! Found: html-webpack-plugin@5.5.0 npm ERR! node_modules/html-webpack-plugin npm ERR! dev html-webpack-plugin@"^5.5.0" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer html-webpack-plugin@"^2.30.1 || ^3.0.6" from svg-sprite-html-webpack@2.4.0 npm ERR! node_modules/svg-sprite-html-webpack npm ERR! dev svg-sprite-html-webpack@"^2.4.0" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

This is the package.json configuration:

"dependencies": { "esbuild-loader": "^2.20.0", "copy-webpack-plugin": "^11.0.0", "css-loader": "^6.5.0", "file-loader": "^6.2.0", "html-loader": "^4.2.0", "mini-css-extract-plugin": "^2.6.1", "portfinder-sync": "0.0.2", "raw-loader": "^4.0.2", "sass": "^1.54.9", "sass-loader": "^13.1.0", "style-loader": "^3.3.1", "swiper": "^8.4.2", "vercel": "^28.4.12", "webpack": "^5.74.0", "webpack-cli": "^4.10.0", "webpack-dev-server": "^4.11.0", "webpack-merge": "^5.8.0" }, "devDependencies": { "html-webpack-plugin": "^5.5.0", "nunjucks": "^3.2.3", "simple-nunjucks-loader": "^3.2.0", "svg-sprite-html-webpack": "^2.4.0" }

Do you find something wrong? Can you help me?

Thanks

@Epimodev
Copy link
Owner

You're welcome!

I never used this plugin with webpack 5 (the update was made by someone else who need webpack 5 compatibility).

But it looks like this is just a mismatch between peer dependencies in this plugin and your version of html-webpack-plugin. But once again I think we missed to update this part during webpack 5 update. I think you can ignore this message it should works well.

@Amaca
Copy link
Contributor Author

Amaca commented Jan 10, 2023

i tried changing your package.json locally updating all the dependencies and peer with latest versions. It seems working. I also edited the readme, if you want. I can make a pull request, Actually i think i need your permission to push the new branch, don't i?

@Epimodev
Copy link
Owner

Great!

You can create a pull request by creating a fork of this repository (this is how it works for all public repository)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants