Update for webpack5 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Epimodev
requested changes
Jul 22, 2021
There was a problem hiding this comment.
@christianopaets thanks a lot for this pull request!
As it's been a long time I didn't use webpack, I didn't try yet if it works well. But I've already a few suggestions. If you disagree don't hesitate to tell me and explain why :-)
|
Thank you for your answer. I've made some changes and tested with old version of webpack and html-webpack-plugin. Now it works fine))) |
Epimodev
reviewed
Jul 22, 2021
|
@christianopaets I just published version 2.4.0 with your changes |
|
@Epimodev thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can fix errors with the newest version of html-webpack-plugin and webpack5