Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sklearn train_test_split in place of StratifiedShuffleSplit #99

Closed
rhiever opened this issue Mar 1, 2016 · 4 comments
Closed

Use sklearn train_test_split in place of StratifiedShuffleSplit #99

rhiever opened this issue Mar 1, 2016 · 4 comments

Comments

@rhiever
Copy link
Contributor

rhiever commented Mar 1, 2016

The latest version of sklearn's train_test_split automatically stratifies the data by class(es) and shuffles the data prior to the split. Thus, we don't need to use the long-form version with StratifiedShuffleSplit.

Let's replace all of the StratifiedShuffleSplit calls with train_test_split.

@pronojitsaha
Copy link
Contributor

Ok..will look into this.

@rhiever
Copy link
Contributor Author

rhiever commented Mar 6, 2016

Ping. How's this coming along? Should I mark it as "being worked on"?

@pronojitsaha
Copy link
Contributor

Yes, I did give it a try couple of days back, but getting some spurious results. Checking on it. yes you can mark it.

@pronojitsaha
Copy link
Contributor

Have sent across the PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants