Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concatenate user defined name and generated by Orion #118

Closed
dmitriy-serdyuk opened this issue Jul 6, 2018 · 6 comments
Closed

Concatenate user defined name and generated by Orion #118

dmitriy-serdyuk opened this issue Jul 6, 2018 · 6 comments
Labels
feature Introduces a new feature

Comments

@dmitriy-serdyuk
Copy link
Contributor

As in (or similar syntax)

--model-name~model_'trial.has_name'
@tsirif tsirif changed the title [Feature Request] Concatenate user defined name and generated by Orion Concatenate user defined name and generated by Orion Jul 6, 2018
@tsirif tsirif added the feature Introduces a new feature label Jul 6, 2018
@tsirif
Copy link
Member

tsirif commented Jul 6, 2018

Current regex will parse out the model_'trial.hash_name'. Perhaps adding another one like [A-Za-z_]*'(.*)' will do the job. However I am not sure how easy it will be now to disentagle the possible cases that come after marker ~.

@dmitriy-serdyuk Can you describe a case where this feature is going to be useful or convenient? Why is it needed?

@dmitriy-serdyuk
Copy link
Contributor Author

I want to give my experiment a human-readable name. I could use this name to generate pretty plots, for example. But I still need different names to save checkpoints separately for each model.

Maybe you can provide a function cat("model_", trial.hash_name) or an operator "model_" + trial.hash_name? I don't know much about internals of Orion, but it seems that it is a mini language already with functions and variables.

@bouthilx
Copy link
Member

bouthilx commented Jul 6, 2018

I would rather use templates. Something like --model-name model_{trial.has_name}. We shouldn't need the ~ sign other than for dimensions.

@bouthilx
Copy link
Member

bouthilx commented Jul 6, 2018

@tsirif If you agree with the solution using templates we could close this issue.

@tsirif
Copy link
Member

tsirif commented Jul 7, 2018 via email

@bouthilx
Copy link
Member

bouthilx commented Jul 7, 2018

See #119

@bouthilx bouthilx closed this as completed Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Introduces a new feature
Projects
None yet
Development

No branches or pull requests

3 participants