Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when user script fails #709

Open
bouthilx opened this issue Dec 9, 2021 · 1 comment
Open

Improve error message when user script fails #709

bouthilx opened this issue Dec 9, 2021 · 1 comment
Labels
enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt) good first issue Indicates a good issue for first-time contributors
Milestone

Comments

@bouthilx
Copy link
Member

bouthilx commented Dec 9, 2021

The current error message is misleading: orion.core.worker.consumer.ExecutionError: Something went wrong. Check logs. Process returned with code -9 !

First, there are no clear mentions that the issue is that the user's script crashed. This should be clearly mentioned. Second, Check logs sounds like it Oríon was writting some logs somewhere. It is not the case. The error message should only state the the user's script failed, and the user will know that it should look at the output of the script to see if there is an error message.

On the same topic, is the error message from the script printed in the terminal? For example if the user's script is written in Python, would the stack-trace be printed? It should be.

@bouthilx bouthilx added enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt) good first issue Indicates a good issue for first-time contributors labels Dec 9, 2021
@bouthilx bouthilx added this to the v0.2.2 milestone Jan 31, 2022
@bouthilx
Copy link
Member Author

Error message was changed in PR #684. We would need to verify that the new error message is useful and adapt it if necessary. Otherwise most important thing is to verify that the call to subprocess.Popen is not catching all stdin/stderr so that the script's stack-trace is visible in the terminal for the user.

nurbal added a commit to nurbal/orion that referenced this issue Feb 2, 2022
Detects if a by-design crashing black-box script Traceback is visible in the stderr output of orion.
@bouthilx bouthilx modified the milestones: v0.2.2, v0.2.3 Feb 13, 2022
@bouthilx bouthilx modified the milestones: v0.2.3, v0.2.5 Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt) good first issue Indicates a good issue for first-time contributors
Projects
None yet
Development

No branches or pull requests

1 participant