Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix benchmark ranking and regret visualization #620

Merged
merged 1 commit into from
Jul 8, 2021
Merged

fix benchmark ranking and regret visualization #620

merged 1 commit into from
Jul 8, 2021

Conversation

donglinjy
Copy link
Collaborator

Fix:

  1. banchmark experiment parallel execution parameter is inconsistent with experimentclient.workon
  2. Rankings plot show wrong and different result compared with regrets

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

@donglinjy donglinjy requested a review from bouthilx June 19, 2021 14:20
bouthilx
bouthilx approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@bouthilx bouthilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bouthilx bouthilx merged commit 20e28d4 into Epistimio:develop Jul 8, 2021
@bouthilx bouthilx mentioned this pull request Aug 23, 2021
Closed
@bouthilx bouthilx added the bug Indicates an unexpected problem or unintended behavior label Aug 23, 2021
@bouthilx bouthilx added this to the v0.1.16 milestone Aug 23, 2021
@bouthilx bouthilx added this to In progress in Release v0.1.16 via automation Aug 23, 2021
@bouthilx bouthilx mentioned this pull request Aug 23, 2021
Merged
@bouthilx bouthilx moved this from In progress to Done in Release v0.1.16 Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouthilx bouthilx bouthilx approved these changes

Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release v0.1.16
Done
Milestone
v0.1.16
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@donglinjy @bouthilx