Fix TPE sampling in narrow spaces #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: The GMM for real values could not sample efficiently in narrow spaces. It would often lead to RuntimeError because the number of attempts allowed would be exhausted. We could increase the default number of attempts allowed but that would increase the computational cost for any space, even those easy to sample. How: Use numpy array to avoid playing with a list. It is more efficient. Also, increase the number of attempts as needed until it reaches a max value of attempts. This way easy samples do not take more time while difficult ones are allowed more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Solves #647]
Why:
The GMM for real values could not sample efficiently in narrow spaces.
It would often lead to RuntimeError because the number of attempts
allowed would be exhausted. We could increase the default number of
attempts allowed but that would increase the computational cost for any
space, even those easy to sample.
How:
Use numpy array to avoid playing with a list. It is more efficient.
Also, increase the number of attempts as needed until it reaches a max
value of attempts. This way easy samples do not take more time while
difficult ones are allowed more.