Clear error message for dup branching error #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: When trying to branch from an experiment that already has a child with the same name, Oríon will crash with a RaceCondition error. The problem is that this issue and a real race-condition are indiscernible as they lead to the same state. The only thing we can do is clarify the error message and warn that this error can also be caused by branching from a parent experiment that already has a child with the same name. Note: This issue only arises if the user specifies the version of the parent experiment, otherwise the EVC will use the child or branch from the child without any issue.
bouthilx
added
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fixes #533]
Why:
When trying to branch from an experiment that already has a child with
the same name, Oríon will crash with a RaceCondition error. The problem
is that this issue and a real race-condition are indiscernible as they
lead to the same state. The only thing we can do is clarify the error
message and warn that this error can also be caused by branching from a
parent experiment that already has a child with the same name.
Note:
This issue only arises if the user specifies the version of the parent
experiment, otherwise the EVC will use the child or branch from the
child without any issue.