Fix shape argument in categorical dims #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: The shape of categorical dimensions was not included in `get_prior_string`, causing the lost of the shape during branching. How: Add the shape to `get_prior_string` of Categorical dimensions and add tests to catch this issue. Also add tests for Conflict and Resolutions of priors with different shape. The adaptor for a change of prior does not raise an issue anymore when shapes are different and rather logs a warning. The trials are all ignored is this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fixes #535]
Why:
The shape of categorical dimensions was not included in
get_prior_string, causing the lost of the shape during branching.How:
Add the shape to
get_prior_stringof Categorical dimensions and addtests to catch this issue.
Also add tests for Conflict and Resolutions of priors with different
shape.
The adaptor for a change of prior does not raise an issue anymore when
shapes are different and rather logs a warning. The trials are all
ignored is this case.