Use user_script_config from parser in EVC #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: The option `user_script_config` is part of the worker configuration, not the EVC. As such, this option is not part of `branching` group of option and does not find its way to the Conflict objects of the EVC. The value of user_script_config is already available anyway inside the experiment configuration, so there is no need to pass it. Furthermore, it may differ from past experiments to the new one, and both experiments should be handled based on their respective `user_script_config`, not the new one. For these reasons, it is better to use the information available in the experiment configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fixes #636]
Why:
The option
user_script_configis part of the worker configuration, notthe EVC. As such, this option is not part of
branchinggroup of optionand does not find its way to the Conflict objects of the EVC. The value
of user_script_config is already available anyway inside the
experiment configuration, so there is no need to pass it. Furthermore, it may
differ from past experiments to the new one, and both experiments should be handled
based on their respective
user_script_config, not the new one. Forthese reasons, it is better to use the information available in the
experiment configurations.