Support batched promotions in ASHA #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: Currently only one promotion can be done for each suggest. This means with pool-size greater than 1 ASHA would always end up suggesting many new trials and only do 1 promotion at a time.
bouthilx
force-pushed
the
hotfix/asha_batch_suggest
branch
from
4c8fd41
to
f997a3c
Compare
bouthilx
force-pushed
the
hotfix/asha_batch_suggest
branch
from
9d84282
to
9cc7c5f
Compare
Why: The deep copy required to save algorithm's state needed to deepcopy all brackets, which are already copied as another attribute. We should instead keep indices to corresponding bracket so that the dictionary is more lightweight during the copy.
bouthilx
force-pushed
the
hotfix/asha_batch_suggest
branch
from
fe04dab
to
23df886
Compare
Merged
bouthilx
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Currently only one promotion can be done for each suggest. This means
with pool-size greater than 1 ASHA would always end up suggesting many
new trials and only do 1 promotion at a time.