(re) Fix parsing of hps with "." in name from commandline #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com> Remove unused imports Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com> Remove little type hint, because. Just because. Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com> Fix failing test Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com> More general fix for other types of characters Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com> Add weirder test-case to test_orion_cmdline_parser Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com> Move the weird arg into parametrized fixture Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com> Improve test_orion_cmdline_parser.py (see desc) - Use a parametrized fixture for generating weird arguments - Added type-hints everywhere in the test module. Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com> Fix isort error Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
bouthilx
approved these changes
Feb 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New / improved of #775
Fixes #769