Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests run with no extras and all extras #810

Merged
merged 9 commits into from
Mar 8, 2022
Merged

Tests run with no extras and all extras #810

merged 9 commits into from
Mar 8, 2022

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Feb 22, 2022

No description provided.

@lebrice
Tests run with no extras and all extras
43213e0 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@bouthilx
Copy link
Member

Thanks for the PR! I think the way you handled this in tox.ini is great! There are some fixes that will be required in the code. Namely the configuration test that rely on dask should be changed to singleexecutor.

github-action build.yaml should be changed to add a test running with no dependency. I'd say with python 3.9 version. And the current matrix execution for python 3.6 to 3.9 should be executed with all.

@lebrice
Add test_without_extras block to build.yaml
b0c7ed0 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Fix typo in build.yaml
047bc75 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Remove dask in test_all_options.py
c8f1fce 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Fix indent, remove version matrix
337d7a2 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add skipif and xfails to executor tests for Dask
965b223 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add xfail mark for Dask param in test_futures.py
21756c5 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Fix isort issue
a8f179c 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
bouthilx
bouthilx approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@bouthilx bouthilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Thanks a lot for this PR!

@lebrice lebrice merged commit cbdfb8f into Epistimio:develop Mar 8, 2022
@bouthilx bouthilx mentioned this pull request Mar 9, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouthilx bouthilx bouthilx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lebrice @bouthilx