Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BOHB #848

Merged
merged 20 commits into from
May 16, 2022
Merged

Add BOHB #848

merged 20 commits into from
May 16, 2022

Conversation

bouthilx
Copy link
Member

Fixes #841

lebrice
lebrice requested changes Mar 24, 2022
View reviewed changes
src/orion/algo/bohb.py Outdated Show resolved Hide resolved
src/orion/algo/bohb.py Outdated Show resolved Hide resolved
src/orion/algo/bohb.py Outdated Show resolved Hide resolved
src/orion/algo/bohb.py Outdated Show resolved Hide resolved
src/orion/algo/bohb.py Outdated Show resolved Hide resolved
src/orion/algo/bohb.py Outdated Show resolved Hide resolved
bouthilx and others added 9 commits April 1, 2022 13:17
@bouthilx @lebrice
super()
4ccebd5 
Co-authored-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@bouthilx @lebrice
super()
5beabeb 
Co-authored-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@bouthilx @lebrice
super()
7f66e80 
Co-authored-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@bouthilx @lebrice
no object inheritance
eb4b034 
Co-authored-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@bouthilx @lebrice
super()
1803916 
Co-authored-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@bouthilx
Fix doc
d7ec60b
@bouthilx
Merge branch 'feature/bohb' of github.com:bouthilx/orion into feature…
664b23e 
…/bohb
@bouthilx
Merge branch 'develop' into feature/bohb
99bc92d
@bouthilx
black
2df8ce9
@bouthilx bouthilx requested a review from lebrice April 13, 2022 12:33
lebrice
lebrice approved these changes Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@lebrice lebrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Why does CodeCov complain so much about the coverage though?

@bouthilx
Copy link
Member Author

Oh yeah, there's actually many parts of the code that aren't covered by the tests. I should fix this.

@bouthilx bouthilx merged commit e50e047 into Epistimio:develop May 16, 2022
@bouthilx bouthilx added the feature Introduces a new feature label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lebrice lebrice lebrice approved these changes

Assignees
No one assigned
Labels
feature Introduces a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate orion.algo.bohb
3 participants
@bouthilx @lebrice @abergeron