Detect _param_names from __init__ signature #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
bouthilx
reviewed
Mar 29, 2022
tests/unittests/algo/test_base.py
Outdated
| # super().__init__(self, **kwargs), then what should the _arg_names be? Should we just raise a | ||
| # warning in that case? Or just assume that the algo will create its own configuration dict? | ||
| # (could also raise a warning only inside the `configuration` property, in the case where we | ||
| # can't fetch the value of the kwargs argument) |
There was a problem hiding this comment.
Algo configuration is expected to be compliant with algorithm's constructor signature, so that we can build an algorithm with AlgoClass(space, **configuration). I think we could safely ignore any of kwargs and rely on the signature.
Also, setting the attributes by passing them to super() is always very confusing to new contributiors. I would be in favor of deprecating this and force algos to set their attributes themselves using self.attr = attr.
There was a problem hiding this comment.
Ok, so you're ok with these changes then? (I'll remove the comment)
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
bouthilx
approved these changes
Mar 31, 2022
bouthilx
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #860 (just the
__init__part)