Fix IndexError for freshly branched exp #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plotting backend functions require a trial to read the objective of the experiment. A freshly branched experiment has no own trials, so we fetch those from the evc tree instead.
|
Thanks for this PR! You can fix the black issue by running locally |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The plotting backend functions fetch a trial of the experiment to infer the objective. For a freshly branched experiment that doesn't have trials yet, the trial list is empty. This results in an IndexError when the functions try to access the first element of the
fetch_trials_by_status()calls here and here.Changes
This PR changes the
fetch_trials_by_statuscalls to copy the plotting functions'with_evc_treearguments to (optionally) fetch trials from prior versions of the experiment if thewith_evc_treeflag is set toTrue.Checklist
Optional:
not with_evc_treeand the current experiment does not have trials yet that is shown instead of the IndexError.Tests
Didn't have time to run tests, sorry :/
Documentation
N/A
Quality
$ tox -e lint)