Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependabot issues #926

Merged
merged 3 commits into from
May 27, 2022
Merged

Fix dependabot issues #926

merged 3 commits into from
May 27, 2022

Conversation

notoraptor
Copy link
Collaborator

Description

Hi @bouthilx ! This is a PR to fix dependabot issues ! I tested it on my fork, and it seems to work.

Changes

All changes occur in dashboard:

  • Remove some unused packages to remove certain issues
  • Update some other packages to fix certain issues
  • Force resolution of specific packages to fix certain issues and inconvenient warning messages
  • Update code to adjust to removed/updated packages:
    • Re-use axios to make API calls, since http module is not available anymore due to updates
    • Remove .env file as it seems unnecessary now and instead disturbs yarn start

Checklist

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

@notoraptor
Dashboard: fix dependabot issues
d4af39c 
- Remove useless package enzyme
- Update package react-scripts, commitlint/cli, lint-staged
- force resolution for dependency nth-check to fix: https://github.com/Epistimio/orion/security/dependabot/13
@notoraptor
Dashboard:
e4a9567 
- use axios instead of http to make API calls. react-scripts 5.0.1 dependencies makes `http` module unavailable, so, go back to axios.
- remove useless packages enzyme-adapter-react-16, graphql and apollo
- remove .env as it seems useless now
@notoraptor
Dashboard: force version of package autoprefixer
5cec644 
- fix warning occuring on "yarn start" since updates: "autoprefixer: Replace color-adjust to print-color-adjust."
- more info: https://stackoverflow.com/questions/72163411/react-bootstarp-warning-about-color-adjust
@bouthilx bouthilx merged commit 22ee120 into Epistimio:develop May 27, 2022
@notoraptor notoraptor deleted the fix-dependabot branch May 30, 2022 16:38
@bouthilx bouthilx added the enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt) label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouthilx bouthilx bouthilx approved these changes

Assignees
No one assigned
Labels
enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@notoraptor @bouthilx