no singleton test #942

Delaunay · 2022-06-06T14:23:10Z

No description provided.

…age to conflict resolution

src/orion/testing/__init__.py

tests/conftest.py

tests/functional/configuration/test_all_options.py

Co-authored-by: Xavier Bouthillier <xavier.bouthillier@gmail.com>

tests/functional/demo/test_demo.py

tests/unittests/core/io/test_experiment_builder.py

tests/unittests/core/worker/test_trial_pacemaker.py

…leton

tests/unittests/core/worker/test_trial_pacemaker.py

tests/unittests/storage/test_legacy.py

Co-authored-by: Xavier Bouthillier <xavier.bouthillier@gmail.com>

…leton

src/orion/testing/__init__.py

bouthilx

No more singletons. At last! 😄

Delaunay added 2 commits June 6, 2022 10:22

no singleton test

f9fb609

use config to create the storage

508a6a3

Delaunay force-pushed the no_singleton branch from fe9835e to 508a6a3 Compare June 6, 2022 14:57

Delaunay added 2 commits June 6, 2022 11:24

Run test to check

6fd116d

Remove reliance on singleton when possible

d548376

Delaunay force-pushed the no_singleton branch from 2bdf0ca to d548376 Compare June 7, 2022 15:33

Delaunay added 24 commits June 7, 2022 12:41

Forward storage to resolution

fec2323

remove some get_storage imports

be01c47

-

5cf114b

-

25f0021

-

2a25e5f

Hunt all setup_storage

236ef3d

Fix test setup

964d89b

-

180e3db

Make sure state sets the config on init

0170030

Patch pickleddb setup issue

db9ad69

Add config reset option

7968209

-

cb38531

-

2aa4086

Make sure exception are printed in debug at the very least, pass stor…

3dd17e1

…age to conflict resolution

-

ca0a449

Propagate more storage instance

2e3895b

Fix some tests

231d2ae

-

3151380

Use orion state for storage setups

b660aa2

-

06454c6

Make sure ExperimentBranchBuilder use a storage

9901b09

-

8288c08

-

9c9b3af

Merge branch 'develop' of github.com:Epistimio/orion into no_singleton

456e4b6

bouthilx reviewed Jul 28, 2022

View reviewed changes

src/orion/testing/__init__.py Show resolved Hide resolved

bouthilx reviewed Jul 28, 2022

View reviewed changes

src/orion/testing/__init__.py Show resolved Hide resolved

bouthilx reviewed Jul 28, 2022

View reviewed changes

tests/conftest.py Show resolved Hide resolved

bouthilx reviewed Jul 28, 2022

View reviewed changes

tests/conftest.py Outdated Show resolved Hide resolved

bouthilx reviewed Jul 28, 2022

View reviewed changes

tests/functional/configuration/test_all_options.py Outdated Show resolved Hide resolved

Update tests/functional/configuration/test_all_options.py

9b85923

Co-authored-by: Xavier Bouthillier <xavier.bouthillier@gmail.com>

bouthilx reviewed Jul 28, 2022

View reviewed changes

tests/functional/demo/test_demo.py Outdated Show resolved Hide resolved

bouthilx reviewed Jul 28, 2022

View reviewed changes

tests/functional/demo/test_demo.py Outdated Show resolved Hide resolved

bouthilx reviewed Jul 28, 2022

View reviewed changes

tests/unittests/core/io/test_experiment_builder.py Show resolved Hide resolved

Add tests for Configuration.from_dict

f5b43d2

bouthilx reviewed Jul 28, 2022

View reviewed changes

tests/unittests/core/worker/test_trial_pacemaker.py Show resolved Hide resolved

Merge branch 'no_singleton' of github.com:Delaunay/orion into no_sing…

1194a43

…leton

bouthilx reviewed Jul 28, 2022

View reviewed changes

tests/unittests/core/worker/test_trial_pacemaker.py Show resolved Hide resolved

bouthilx reviewed Jul 28, 2022

View reviewed changes

tests/unittests/storage/test_legacy.py Outdated Show resolved Hide resolved

bouthilx reviewed Jul 28, 2022

View reviewed changes

tests/unittests/storage/test_legacy.py Outdated Show resolved Hide resolved

Delaunay and others added 7 commits July 28, 2022 12:38

Update tests/unittests/storage/test_legacy.py

04efcb2

Co-authored-by: Xavier Bouthillier <xavier.bouthillier@gmail.com>

Update tests/unittests/storage/test_legacy.py

c85d3b7

Co-authored-by: Xavier Bouthillier <xavier.bouthillier@gmail.com>

-

4958421

Merge branch 'no_singleton' of github.com:Delaunay/orion into no_sing…

ebdeea7

…leton

-

a36817f

-

9520c85

Add comment for why we need to override setup_storage for certain tests

7ce98f8

bouthilx reviewed Jul 28, 2022

View reviewed changes

src/orion/testing/__init__.py Outdated Show resolved Hide resolved

Delaunay added 2 commits July 28, 2022 13:25

-

b2be35c

-

2b9d745

Delaunay marked this pull request as ready for review July 28, 2022 20:31

bouthilx approved these changes Jul 29, 2022

View reviewed changes

bouthilx merged commit 73cc6cd into Epistimio:develop Jul 29, 2022

notoraptor mentioned this pull request Aug 2, 2022

Release 0.2.5rc #980

Merged

bouthilx added the enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt) label Aug 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

no singleton test #942

no singleton test #942

Delaunay commented Jun 6, 2022

bouthilx left a comment

no singleton test #942

no singleton test #942

Conversation

Delaunay commented Jun 6, 2022

bouthilx left a comment

Choose a reason for hiding this comment