Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard/DB page] Display only 7 first characters of trial ID in ID column. #960

Merged
merged 2 commits into from
Jul 6, 2022
Merged

[dashboard/DB page] Display only 7 first characters of trial ID in ID column. #960

merged 2 commits into from
Jul 6, 2022

Conversation

notoraptor
Copy link
Collaborator

Description

Hi @bouthilx ! This is a PR to display only first characters of trial ID in trials table.

Changes

  • Display first 7 characters of a trail ID then 3 points
  • Display full trial ID in a tooltip on mouseover

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

Further comments

Since I am still unable to fix timeout issue for dashboarc tests, I have not added unit tests for these changes here.

bouthilx
bouthilx approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@bouthilx bouthilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@bouthilx bouthilx merged commit f9d8c94 into Epistimio:develop Jul 6, 2022
@notoraptor notoraptor deleted the improve-db-page branch July 7, 2022 18:53
@notoraptor notoraptor mentioned this pull request Aug 2, 2022
Merged
@bouthilx bouthilx added enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt) dashboard labels Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouthilx bouthilx bouthilx approved these changes

Assignees
No one assigned
Labels
dashboard enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@notoraptor @bouthilx