Fix !rejoin regarding max player server count #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… players This is to patch a bug inside roblox where players can have way too many players in it.
|
close this... |
|
How do you do this? Roblox doesn't set up a proper race condition, if many people rejoin at the same time it might just allow the whole queue and the players who were rejoining to be in the server |
|
You can't (and shouldn't) |
|
This shouldn't be merged. This doesn't solve the underlying issue and instead impedes an Adonis function. Max players can be bypass anyway. This has always been the case, rejoin technically makes it easier. As this isn't a problem for most games, you could instead enforce the limit in your game, kicking additional players. You could theoretically make some kind of anti protection in Adonis, but I don't think anyone would find it useful. |
|
Yea if this was added in settings (disabled by default) then I'd add it |
Will modify it, thanks! |
|
settings file bloat mmmmmmmmm |
Bro what's wrong with you 😭 |
people like you are why the settings file is nearing 700 lines. 700 LINES WHAT IS WRONG WITH YOU??? |
|
"HELO CAN I HAVE ONE |
i'd prefer if some 12 year old would stop bumping the pull request based on off-related topics. |
THIS IS REAL CODE DONE BY REAL PROGRAMMERS LOOK AT WHAT YOU'VE BEEN DEMANDING OUR RESPECT FOR
|
Dimenpsyonal
added a commit
that referenced
this pull request
Mar 11, 2024
* v252 changelog * Update version to v252 * Add Dangerous as command option * Add Dangerous to command t.bool * Disable R15 dog * Make Output functions actually work * Add colon * Add output title * Add output title * Update output titles * Made ping readout show in ms (#1420) Before it would always show 0, this remedy's that Also sunk in a little grammar fix * Update Changelog * Add Dangerous command option (#1418) * Add WarnDangerousCommand to defaultsettings * Add WarnDangerousCommand to settings * Add Dangerous as command option * Fix !rejoin regarding max player server count (#1415) * Disable !rejoin when player count is equal or greater than max server players This is to patch a bug inside roblox where players can have way too many players in it. * Update DefaultSettings.lua 1/2 * Update DefaultSettings.lua 1.5/2 * Update settings.lua 1.75/2 * Implement setting to disable rejoin at max players 2/2 * Add DisableRejoinAtMaxPlayers to Order and Descs * Add DisableRejoinAtMaxPlayers to order and descs --------- Co-authored-by: Dimenpsyonal <64012878+Dimenpsyonal@users.noreply.github.com> * Update Changelog * Lazy load userpanel (#1407) * Lazy load userpanel * Update UserPanel.lua * Fix missing variable * Optimise code * Fix invalid properties * Fix hardcoded prefix * Only get variables if there is a window * Re-add hardcoded prefix --------- Co-authored-by: Dimenpsyonal <64012878+Dimenpsyonal@users.noreply.github.com> * Update Changelog v252 * Update Functions output * Update ScriptEditor output * Delete MainModule/Server/Plugins/ServerNewDex.rbxmx * Update newdex Remove capitalisation from commands and add :newdex as a command * Update changelog * Add title to WindowsXP output * Turn richtext on for windowsXP * Add * Add additional Output features to Steampunk * Add additonal Output features to Rounded * Add additional output functions to Aero * Add additional output functions to Unity * Update Changelog * Disable singer by default * Keybinds input fix (#1422) * Keybinds input fix Fixes issue where after selecting a key it would still continuously wait for keys to be input. * Small Old logs fix Should check if it's a string instead of any other type. * Update Changelog * Add Setting "ChatCreateRobloxCommands" to configure whether or not one wants Roblox Chat Commands to be generated (#1423) * Add "ChatCreateRobloxCommands" * Add "ChatCreateRobloxCommands" * Setting "ChatCreateRobloxCommands" to determine whether or not to create Roblox Chat Commands * Add a setting to determine whether or not to create Roblox Chat Commands * Update Changelog * Add FastLoadUserpanel to variables * Add FastLoad Userpanel to client settings * Add default value if var is blank * Fix typo * Option to disable FastLoad * Update logic * Silence playerdata error * Silence errors * Update Changelog * Change meta files from Disabled to Enabled (#1424) * Update enabled to disabled * Swap around layout * Update Changelog * Fix text being editable in lists (#1425) * Update Changelog * Make dangerous commands prompt before being executed. (#1426) * Add mark as dangerous functionality * Fix linter issue * Add WarnDangerousCommand setting * Add dangerous tags to commands. * Move dangerous command warning from `Admin.RunCommandAsPlayer` to `Process.Command` * Fix linter errors. * Whoops, haven't seen that one. * Remove dangerous checks from direct ban related commands. * Bug fixes. Co-authored-by: fxeP1 <fxe@riseup.net> --------- Co-authored-by: fxeP1 <fxe@riseup.net> * Update description of `:nil` command. (#1427) * Deprecate :nil * Update Admins.lua * Update Changelog * Update Changelog, include contributors * Move the sword command into fun commands. (#1428) * Revert "Fix text being editable in lists (#1425)" (#1432) This reverts commit 99ff7e0. * Update Changelog. * Update Changelog * Read HttpEnabled directly * Fix :unfly command not working when SignalBehavior is set to Deferred (#1436) * Update Changelog * Remove fastload setting and change loading from ugly text to responsive and beatiful icon (#1434) * Remove `fastloaduserpanel` * Remove `fastloaduserpanel` * Remove `fastloaduserpanel` * Change loading from text to icon * Fix typo * Fix rejoin, again, now another command. (#1438) * Untrack fix for specific players (#1440) Resolves issue where missing `_` would prevent the "untrack" command from properly removing the tracking instance. * Use :GetNetworkPing() accurately (#1439) * Update Changelog.lua * Fix title logic * Fix title logic * Update title logic * Update title logic * Update title logic * Update title logic * Update Changelog date and time * Update Anti_Cheat.lua --------- Co-authored-by: Drew Bokman <61132894+DrewBokman@users.noreply.github.com> Co-authored-by: Radiant <69520693+RadiantUwU@users.noreply.github.com> Co-authored-by: ccuser44 <68124053+ccuser44@users.noreply.github.com> Co-authored-by: fxe <fxep1@riseup.net> Co-authored-by: karl-police <karl-police2001@bluewin.ch> Co-authored-by: kaiserandaxl <122803145+kaiserandaxl@users.noreply.github.com> Co-authored-by: fxeP1 <fxe@riseup.net> Co-authored-by: joritochip <83682212+joritochip@users.noreply.github.com> Co-authored-by: Clown <fatestheadfatheadgaming@gmail.com> Co-authored-by: Coasterteam <21298244+coasterteam@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1416
This is to patch a bug inside roblox where players can have way too many players in it.
This has become apparent to me from users abusing !rejoin to do such things, and instead of out right disabling !rejoin, this should be a good compromise.