Make loadstring use proto conversion #1472

ccuser44 · 2024-04-21T18:39:14Z

Make loadstring use proto conversion instead of serialising to bytecode & deserialising.
Improves performance of compilation by avoiding the bytecode step all together and using the protos directly

Idea from how Roblox exploits used to proto convert

ccuser44 · 2024-04-21T18:39:41Z

~~Can only be merged after #1470~~

ccuser44 · 2024-04-21T19:30:18Z

PoF:

Script:

local band = bit32.band
local bnot = bit32.bnot
local bxor = bit32.bxor

local rrotate = bit32.rrotate
local rshift = bit32.rshift

local primes = 
{
	0x428a2f98, 0x71374491, 0xb5c0fbcf, 0xe9b5dba5,
	0x3956c25b, 0x59f111f1, 0x923f82a4, 0xab1c5ed5,
	0xd807aa98, 0x12835b01, 0x243185be, 0x550c7dc3,
	0x72be5d74, 0x80deb1fe, 0x9bdc06a7, 0xc19bf174,
	0xe49b69c1, 0xefbe4786, 0x0fc19dc6, 0x240ca1cc,
	0x2de92c6f, 0x4a7484aa, 0x5cb0a9dc, 0x76f988da,
	0x983e5152, 0xa831c66d, 0xb00327c8, 0xbf597fc7,
	0xc6e00bf3, 0xd5a79147, 0x06ca6351, 0x14292967,
	0x27b70a85, 0x2e1b2138, 0x4d2c6dfc, 0x53380d13,
	0x650a7354, 0x766a0abb, 0x81c2c92e, 0x92722c85,
	0xa2bfe8a1, 0xa81a664b, 0xc24b8b70, 0xc76c51a3,
	0xd192e819, 0xd6990624, 0xf40e3585, 0x106aa070,
	0x19a4c116, 0x1e376c08, 0x2748774c, 0x34b0bcb5,
	0x391c0cb3, 0x4ed8aa4a, 0x5b9cca4f, 0x682e6ff3,
	0x748f82ee, 0x78a5636f, 0x84c87814, 0x8cc70208,
	0x90befffa, 0xa4506ceb, 0xbef9a3f7, 0xc67178f2,
}

local function toHex(str)
	local result = str:gsub('.', function (char)
		return string.format("%02x", char:byte())
	end)
	
	return result
end

local function toBytes(value, length)
    local str = ""
	
    for i = 1, length do
        local rem = value % 256
        str = string.char(rem) .. str
        value = (value - rem) / 256
    end
	
    return str
end

local function readInt32(buffer, index)
    local value = 0
	
    for i = index, index + 3 do 
		value = (value * 256) + string.byte(buffer, i)
	end
	
    return value
end

local function digestBlock(msg, i, hash)
	local digest = {}
	
	for j = 1, 16 do 
		digest[j] = readInt32(msg, i + (j - 1) * 4) 
	end
	
	for j = 17, 64 do
		local v = digest[j - 15]
		local s0 = bxor(rrotate(v, 7), rrotate(v, 18), rshift(v, 3))
		
		v = digest[j - 2]
		digest[j] = digest[j - 16] + s0 + digest[j - 7] + bxor(rrotate(v, 17), rrotate(v, 19), rshift(v, 10))
	end
	
	local a, b, c, d, e, f, g, h = unpack(hash)
	
	for i = 1, 64 do
		local s0 = bxor(rrotate(a, 2), rrotate(a, 13), rrotate(a, 22))
		local maj = bxor(band(a, b), band(a, c), band(b, c))
		
		local t2 = s0 + maj
		local s1 = bxor(rrotate(e, 6), rrotate(e, 11), rrotate(e, 25))
		
		local ch = bxor(band(e, f), band(bnot(e), g))
		local t1 = h + s1 + ch + primes[i] + digest[i]
		
		h, g, f, e, d, c, b, a = g, f, e, d + t1, c, b, a, t1 + t2
	end
	
	hash[1] = band(hash[1] + a)
	hash[2] = band(hash[2] + b)
	hash[3] = band(hash[3] + c)
	hash[4] = band(hash[4] + d)
	hash[5] = band(hash[5] + e)
	hash[6] = band(hash[6] + f)
	hash[7] = band(hash[7] + g)
	hash[8] = band(hash[8] + h)
end

local function sha256(msg)
	do
		local extra = 64 - ((#msg + 9) % 64)
		local len = toBytes(8 * #msg, 8)
		
		msg = msg .. '\128' .. string.rep('\0', extra) .. len
		assert(#msg % 64 == 0)
	end
	
	local hash = 
	{
		0x6a09e667,
		0xbb67ae85,
		0x3c6ef372,
		0xa54ff53a,
		0x510e527f,
		0x9b05688c,
		0x1f83d9ab,
		0x5be0cd19,	
	}
	
	for i = 1, #msg, 64 do 
		digestBlock(msg, i, hash)
	end
	
	local result = ""
	
	for i = 1, 8 do
		local value = hash[i]
		result = result .. toBytes(value, 4)
	end
	
	return toHex(result)
end

------------------------------------------------------------------

local input = string.rep(".", 26e4)

local now = tick()
local result = sha256(input)

print(tick() - now)
print(result)

------------------------------------------------------------------

Infraction7

Line 14, column 13 "DEPENDENCIES" is misspelled

ccuser44 · 2024-04-22T07:15:03Z

Line 14, column 13 "DEPENDENCIES" is misspelled

Fixed

ccuser44 · 2024-04-23T08:08:51Z

Fixed merge conflict

Infraction7

all right

ccuser44 · 2024-04-27T10:50:27Z

PoF:

Script:

local band = bit32.band
local bnot = bit32.bnot
local bxor = bit32.bxor

local rrotate = bit32.rrotate
local rshift = bit32.rshift

local primes = 
{
	0x428a2f98, 0x71374491, 0xb5c0fbcf, 0xe9b5dba5,
	0x3956c25b, 0x59f111f1, 0x923f82a4, 0xab1c5ed5,
	0xd807aa98, 0x12835b01, 0x243185be, 0x550c7dc3,
	0x72be5d74, 0x80deb1fe, 0x9bdc06a7, 0xc19bf174,
	0xe49b69c1, 0xefbe4786, 0x0fc19dc6, 0x240ca1cc,
	0x2de92c6f, 0x4a7484aa, 0x5cb0a9dc, 0x76f988da,
	0x983e5152, 0xa831c66d, 0xb00327c8, 0xbf597fc7,
	0xc6e00bf3, 0xd5a79147, 0x06ca6351, 0x14292967,
	0x27b70a85, 0x2e1b2138, 0x4d2c6dfc, 0x53380d13,
	0x650a7354, 0x766a0abb, 0x81c2c92e, 0x92722c85,
	0xa2bfe8a1, 0xa81a664b, 0xc24b8b70, 0xc76c51a3,
	0xd192e819, 0xd6990624, 0xf40e3585, 0x106aa070,
	0x19a4c116, 0x1e376c08, 0x2748774c, 0x34b0bcb5,
	0x391c0cb3, 0x4ed8aa4a, 0x5b9cca4f, 0x682e6ff3,
	0x748f82ee, 0x78a5636f, 0x84c87814, 0x8cc70208,
	0x90befffa, 0xa4506ceb, 0xbef9a3f7, 0xc67178f2,
}

local function toHex(str)
	local result = str:gsub('.', function (char)
		return string.format("%02x", char:byte())
	end)
	
	return result
end

local function toBytes(value, length)
    local str = ""
	
    for i = 1, length do
        local rem = value % 256
        str = string.char(rem) .. str
        value = (value - rem) / 256
    end
	
    return str
end

local function readInt32(buffer, index)
    local value = 0
	
    for i = index, index + 3 do 
		value = (value * 256) + string.byte(buffer, i)
	end
	
    return value
end

local function digestBlock(msg, i, hash)
	local digest = {}
	
	for j = 1, 16 do 
		digest[j] = readInt32(msg, i + (j - 1) * 4) 
	end
	
	for j = 17, 64 do
		local v = digest[j - 15]
		local s0 = bxor(rrotate(v, 7), rrotate(v, 18), rshift(v, 3))
		
		v = digest[j - 2]
		digest[j] = digest[j - 16] + s0 + digest[j - 7] + bxor(rrotate(v, 17), rrotate(v, 19), rshift(v, 10))
	end
	
	local a, b, c, d, e, f, g, h = unpack(hash)
	
	for i = 1, 64 do
		local s0 = bxor(rrotate(a, 2), rrotate(a, 13), rrotate(a, 22))
		local maj = bxor(band(a, b), band(a, c), band(b, c))
		
		local t2 = s0 + maj
		local s1 = bxor(rrotate(e, 6), rrotate(e, 11), rrotate(e, 25))
		
		local ch = bxor(band(e, f), band(bnot(e), g))
		local t1 = h + s1 + ch + primes[i] + digest[i]
		
		h, g, f, e, d, c, b, a = g, f, e, d + t1, c, b, a, t1 + t2
	end
	
	hash[1] = band(hash[1] + a)
	hash[2] = band(hash[2] + b)
	hash[3] = band(hash[3] + c)
	hash[4] = band(hash[4] + d)
	hash[5] = band(hash[5] + e)
	hash[6] = band(hash[6] + f)
	hash[7] = band(hash[7] + g)
	hash[8] = band(hash[8] + h)
end

local function sha256(msg)
	do
		local extra = 64 - ((#msg + 9) % 64)
		local len = toBytes(8 * #msg, 8)
		
		msg = msg .. '\128' .. string.rep('\0', extra) .. len
		assert(#msg % 64 == 0)
	end
	
	local hash = 
	{
		0x6a09e667,
		0xbb67ae85,
		0x3c6ef372,
		0xa54ff53a,
		0x510e527f,
		0x9b05688c,
		0x1f83d9ab,
		0x5be0cd19,	
	}
	
	for i = 1, #msg, 64 do 
		digestBlock(msg, i, hash)
	end
	
	local result = ""
	
	for i = 1, 8 do
		local value = hash[i]
		result = result .. toBytes(value, 4)
	end
	
	return toHex(result)
end

------------------------------------------------------------------

local input = string.rep(".", 26e4)

local now = tick()
local result = sha256(input)

print(tick() - now)
print(result)

------------------------------------------------------------------

ccuser44 added 2 commits April 21, 2024 21:33

Add proto conversion

606b841

Make FiOne expose internal functionality

2d7bff7

ccuser44 marked this pull request as draft April 21, 2024 18:39

ccuser44 added 5 commits April 21, 2024 21:40

Fix typo

ebb74b8

Fix typo

83c40ff

Fix typos

49604b7

Fix typo

00f4e88

Fix signed Bx register handling

fedbc18

ccuser44 added 3 commits April 21, 2024 22:31

Fix FiOne return

bfce9a8

Add comment about fix

adf0ff0

Update FiOne.lua

a5130a1

Dimenpsyonal added the ✨ enhancement Enhancing or improving existing functionality label Apr 21, 2024

$Infraction7$

Infraction7 suggested changes Apr 22, 2024

View reviewed changes

Fix typo

c66ac40

ccuser44 requested a review from Infraction7 April 22, 2024 07:15

ccuser44 added 4 commits April 22, 2024 11:55

Create VirtualEnv.lua

6d94f5b

Fix script variable

af80020

Fix issue with compilation

529e98b

Fix bytecode compilation

7da401a

Dimenpsyonal added the ⌛needs PoF This PR is awaiting proof of functionality label Apr 22, 2024

Fix assert condition

7115013

ccuser44 marked this pull request as ready for review April 23, 2024 08:08

Merge branch 'master' into patch-7

ff7e802

Fix lint

38dfc26

$Infraction7$

Infraction7 approved these changes Apr 24, 2024

View reviewed changes

Fix typo

b32f62a

ccuser44 added 21 commits April 25, 2024 17:34

Clean up upval size

475168a

Update FiOne.lua

96d562b

Update init.lua

9f58459

Fix scriptbase not running with proto-conversion + optimisation

0738dee

Optimise localscriptbase

e506101

Optimise script commands

011dc1a

Scriptbase to use proto conversion. Fixes Epix-Incorporated#1475

aa28c02

Better var name

0f8d4b0

Better var name

66d0829

Fix typo

5a44cbe

Fix typo

33f3d57

Fix typo

6a746d9

Fix typo

e6be5a5

Metatable fix

d821bec

Fix wrap

c3bbaf7

Fix wrap

7009822

Fix wrap

f50d41e

Fix wrap

669a9d9

Final fix

b3ab5ed

Update Server.lua

59f8aa9

Update Core.lua

5ad9183

Dimenpsyonal merged commit fa2eae8 into Epix-Incorporated:master Apr 27, 2024
2 checks passed

ccuser44 deleted the patch-7 branch April 27, 2024 10:51

ccuser44 mentioned this pull request Apr 29, 2024

Added Luau global import optimisation #1486

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make loadstring use proto conversion #1472

Make loadstring use proto conversion #1472

ccuser44 commented Apr 21, 2024

ccuser44 commented Apr 21, 2024 •

edited

Loading

ccuser44 commented Apr 21, 2024

$@Infraction7$ Infraction7 left a comment

ccuser44 commented Apr 22, 2024

ccuser44 commented Apr 23, 2024

$@Infraction7$ Infraction7 left a comment

ccuser44 commented Apr 27, 2024

Make loadstring use proto conversion #1472

Make loadstring use proto conversion #1472

Conversation

ccuser44 commented Apr 21, 2024

ccuser44 commented Apr 21, 2024 • edited Loading

ccuser44 commented Apr 21, 2024

Infraction7 left a comment

Choose a reason for hiding this comment

ccuser44 commented Apr 22, 2024

ccuser44 commented Apr 23, 2024

Infraction7 left a comment

Choose a reason for hiding this comment

ccuser44 commented Apr 27, 2024

ccuser44 commented Apr 21, 2024 •

edited

Loading

$@Infraction7$ Infraction7 left a comment

$@Infraction7$ Infraction7 left a comment