Log changes + Minor fixes towards modules #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Core`: Cleanup for junk data removal. `Server`: Remove CloneTable duplicate reference Set CloneTable to use the Server.lua version, shouldn't effect anything (hopefully?, we may have issues with metatables?) `Moderators`: Fix typo Track fix
`Anti`: Remove useless "strings" for "detections" destroy "Test" StringValue after pcall is finished (save on instances) `UI/Default/Music`: Fix code bug with processing playlist `Admins`: Fix unadmin bug with none in-game players `Anti`: More type checking to prevent abuse `Core`: Band-aid fix towards "exhaustion", this may cause some games to lag a lot, a more faster solution needs to be mocked up instead of this (if you would like to change it when merging go ahead) `Process`: More type checking and code cleanup Leave/Join logs now include DisplayNames for admin convenience `Remote`: Cleanup of code Huge argument checks to prevent abuse
ccuser44
suggested changes
Dec 22, 2022
Expertcoderz
added
🐛 bug
You probably want to change `\n` to `\t` instead but this should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anti:Remove useless "strings" for "detections"
Destroy "Test" StringValue after pcall is finished (save on instances)
Comment out "LogService" tampering locals as they are currently disabled!
UI/Default/Music:Fix code bug with processing playlist
Admins:Fix unadmin bug with none in-game players
Anti:More type checking to prevent abuse
Core:Band-aid fix towards "exhaustion" of adding bans and other huge entries.
This may cause some games to lag a lot, a more faster solution needs to be mocked up instead of this. If you would like to change it when merging go ahead
Process:More type checking and code cleanup
Leave/Join logs now include DisplayNames for admin convenience
Remote:Cleanup of code
Huge argument checks to prevent abuse