This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
Fix regex for detecting project, context, tag #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the regex for detection of projects, contexts and tags in the todo lines. It switches from "zero or more" quantifier to "one or more" quantifier, because otherwise empty projects or contexts would be allowed and something like "test:" would be a tag.
|
Tag regex is still not very good. I try to find a better solution |
This commit changes the tag regex to not match URLs anymore. The new tag regex matches with the following examples: line: 2018-05-20 h:1 @pc +music us/hh////:a//asdf match1: h:1 match2: us/hh////:a line: 2018-05-19 read http://todotxt.org/ +background match: NONE
|
With the latest commit, URLs are not matched as tags anymore. |
|
Thank you for you PR! I'll release a new version of todotxtio on PyPI soon. Edit: released 0.2.3 https://github.com/EpocDotFr/todotxtio/releases/tag/todotxtio-0.2.3 Edit 2: PyPI package updated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the regex for detection of projects, contexts and tags
in the todo lines. It switches from "zero or more" quantifier to "one or
more" quantifier, because otherwise empty projects or contexts would be
allowed and something like "test:" would be a tag.