Include additional error information in emulator log #34
Conversation
| if(!lock.await(10000, TimeUnit.MILLISECONDS)) { | ||
| throw new RuntimeException("Request for RAC did not complete within timeout"); | ||
| } |
There was a problem hiding this comment.
This is the core change. If CountDownLatch.await() hits it's timeout, it returns false but then continues execution. This can be confusing to the developer, so now we'll throw an error.
First testing this on my bad home wifi, I hit the error 😅 . So, I've extended the timeout to a generous 10 seconds. However, since it's using this await, most of the time we won't actually wait that long.
| @@ -179,8 +179,6 @@ public void testAssignments() { | |||
| public void testErrorGracefulModeOn() { | |||
| try { | |||
| initClient(TEST_HOST, false, true, true); | |||
| System.out.println("Sleeping for a bit to wait for cache population to complete"); | |||
There was a problem hiding this comment.
Don't need these sleeps since we are no formally waiting for the request to complete.
| System.out.println("Sleeping for a bit to wait for cache population to complete"); | ||
| Thread.sleep(1000); | ||
| Thread.sleep(2000); |
There was a problem hiding this comment.
We do still need this sleep though, for asynchronous cache repopulation, but I'm doubling it given how unimpressed I am with GitHub action performance.
| e.printStackTrace(); | ||
| } | ||
| Log.e(TAG, "Http request failure", e); | ||
| Log.e(TAG, "Http request failure: "+e.getMessage()+" "+Arrays.toString(e.getStackTrace()), e); |
There was a problem hiding this comment.
More helpful failure log.
| private static final String TEST_HOST = "https://us-central1-eppo-prod-312905.cloudfunctions.net/serveGithubRacTestFile"; | ||
| private static final String INVALID_HOST = "https://thisisabaddomainforthistest.com"; |
| this.client = buildOkHttpClient(); | ||
| } | ||
|
|
||
| private static OkHttpClient buildOkHttpClient() { | ||
| OkHttpClient.Builder builder = new OkHttpClient().newBuilder() | ||
| .connectTimeout(10, TimeUnit.SECONDS) | ||
| .readTimeout(10, TimeUnit.SECONDS); | ||
|
|
||
| return builder.build(); |
There was a problem hiding this comment.
Made this more obvious it was happening in constructor and set it up for dropping in IpV4-only DNS, which may be needed (but hopefully not 🤞)
Ticket: FF-1133 - Harden waiting for RAC request in Android SDK Test
Motivation: still getting weird failures (see: https://github.com/Eppo-exp/sdk-test-data/actions/runs/6661079552)
I want more information to make it in the uploaded log, and I noticed we only allow 2 seconds for the RAC request to finish and then silently continue on our way. This change increases the timeout to be more generous and throws an error if it does time out, so we're not left scratching our heads.
I added a bit of extra logging, too, which revealed that sometimes the action cannot reach the Google Cloud Function. So I added a little loop to wait up to 15 seconds for DNS to resolve before proceeding.
I also saw the above check pass but android emulator fail, so I switched to HTTPS protocol thinking that may play nicer with DNS.