chore: Prepare for v3.1.0 release #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarsilv
approved these changes
Jun 18, 2024
Comment on lines
+164
to
+173
| if (!project.hasProperty('release') && !project.hasProperty('snapshot')) { | ||
| throw new GradleException("You must specify either -Prelease or -Psnapshot") | ||
| } | ||
| if (project.hasProperty('release') && project.version.endsWith('SNAPSHOT')) { | ||
| throw new GradleException("You cannot specify -Prelease with a SNAPSHOT version") | ||
| } | ||
| if (project.hasProperty('snapshot') && !project.version.endsWith('SNAPSHOT')) { | ||
| throw new GradleException("You cannot specify -Psnapshot with a non-SNAPSHOT version") | ||
| } | ||
| project.ext.shouldPublish = true |
There was a problem hiding this comment.
Appreciate the defensiveness!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump SDK version and some dependencies for v3.1.0 release.
I also had to tweak the build script and workflow files so we can have different workflows for publishing snapshot vs. release artifacts conditionally
Testing
Verified the Sample app launched and assigned correctly
