Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting error in client initialisation. #29

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

njflynn
Copy link
Contributor

@njflynn njflynn commented Jan 12, 2024

Found a bug in the SDK whereby Client initialisation is adding a default assignment logger rather the the one passed as in the config param. As the logger field is not exported this initial assignment cannot be updated.

@leoromanovsky
Copy link
Member

@njflynn thank you for submitting this fix! Sorry for the oversight in our testing - I have augmented the suite in my PR here and will merge it shortly (#30)

@leoromanovsky leoromanovsky merged commit 3326c3f into Eppo-exp:main Jan 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants