Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace ApiKey with SdkKey (FF-2390) #43

Merged
merged 2 commits into from
Jun 10, 2024
Merged

replace ApiKey with SdkKey (FF-2390) #43

merged 2 commits into from
Jun 10, 2024

Conversation

leoromanovsky
Copy link
Member

Standardizing calling the authorization for SDK the SdkKey

question to reviewers

Do you like SdkKey or SDKKey as the parameter name?

@leoromanovsky leoromanovsky marked this pull request as ready for review June 10, 2024 22:55
@felipecsl
Copy link
Member

I prefer SdkKey

@leoromanovsky leoromanovsky merged commit fa764da into main Jun 10, 2024
3 checks passed
@leoromanovsky leoromanovsky deleted the lr/ff-2390/sdk-key branch June 10, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipecsl felipecsl felipecsl approved these changes

@rasendubi rasendubi Awaiting requested review from rasendubi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leoromanovsky @felipecsl