Additional params to experiment hooks methods. Enable hooks in getAssignment
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petzel
force-pushed
the
assignment-hooks-sync-with-more-params
branch
from
d4c2ae7
to
7adbe91
Compare
leoromanovsky
approved these changes
Aug 29, 2023
aarsilv
approved these changes
Aug 30, 2023
| expect(td.explain(mockHooks.onPreAssignment).callCount).toEqual(1); | ||
| expect(td.explain(mockHooks.onPreAssignment).calls[0].args[0]).toEqual('subject-identifer'); | ||
| expect(td.explain(mockHooks.onPreAssignment).calls[0].args[0]).toEqual(experimentName); |
src/client/eppo-client.ts
Outdated
| assignment = this.getAssignment(subjectKey, experimentKey, subjectAttributes); | ||
| // check for overridden assignment via hook | ||
| const overriddenAssignment = assignmentHooks?.onPreAssignment(experimentKey, subjectKey); | ||
| if (overriddenAssignment != null) { |
There was a problem hiding this comment.
Minor but we can strict inequality check here (!==)
leoromanovsky
pushed a commit
that referenced
this pull request
Aug 30, 2023
…signment` (#8) * additional params to experiment hooks methods. enable hooks in getAssignment * only check assignment override after enabled check * ensure logging callback is invoked when overriding via hook * create internal method to avoid multiple calls to log assignment/post assignment callback * add undefined check
leoromanovsky
pushed a commit
that referenced
this pull request
Aug 31, 2023
…signment` (#8) * additional params to experiment hooks methods. enable hooks in getAssignment * only check assignment override after enabled check * ensure logging callback is invoked when overriding via hook * create internal method to avoid multiple calls to log assignment/post assignment callback * add undefined check
leoromanovsky
pushed a commit
that referenced
this pull request
Aug 31, 2023
…signment` (#8) * additional params to experiment hooks methods. enable hooks in getAssignment * only check assignment override after enabled check * ensure logging callback is invoked when overriding via hook * create internal method to avoid multiple calls to log assignment/post assignment callback * add undefined check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IAssignmentHooksasyncin order to potentially perform I/O during a hook invocation. We also got feedback that this isn't necessary/desired, so added the hooks as an optional param to the synchronousgetAssignmentmethod, and removed thegetAssignmentWithHooksmethod.onPreAssignmentafter the enabled check so overrides only take place if the flag is enabled