Add an optional param to provide assignmentCache solution; fallback t… #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,6 +67,8 @@ export interface IClientConfig { | |||
| * Poll for new configurations even if the initial configuration request failed. (default: false) | |||
| */ | |||
| pollAfterFailedInitialization?: boolean; | |||
|
|
|||
| disablePolling?: boolean; | |||
There was a problem hiding this comment.
Consider passing a persistentStore instead which implements isExpired the way you want it:
- interface: https://github.com/Eppo-exp/js-client-sdk/blob/main/src/index.ts#L79
- we have an implementation of a
chrome.storagebacked store that supports a "cooldown" for example: https://github.com/Eppo-exp/js-client-sdk/blob/main/src/chrome.configuration-store.ts#L14 - users on aws lambda can provide a store that reads from dynamodb or redis to avoid fetching from CDN
There was a problem hiding this comment.
Agreed, I think we want to do what Leo said and then expose pollAfterSuccessfulInitialization to prevent polling.
aarsilv
reviewed
May 21, 2024
| @@ -61,6 +67,8 @@ export interface IClientConfig { | |||
| * Poll for new configurations even if the initial configuration request failed. (default: false) | |||
| */ | |||
| pollAfterFailedInitialization?: boolean; | |||
|
|
|||
| disablePolling?: boolean; | |||
There was a problem hiding this comment.
Agreed, I think we want to do what Leo said and then expose pollAfterSuccessfulInitialization to prevent polling.
| /** | ||
| * (optional) Provide your own caching solution. If not defined, LRU cache will be used. | ||
| */ | ||
| assignmentCache?: AssignmentCache<Cacheable>; |
There was a problem hiding this comment.
I like being able to pass in the assignment cache 👍
The Vercel implementation will use their edge file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o LRU
Fixes: #issue
Motivation and Context
Description
How has this been tested?