Upgrade gradle to 5.2.1 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Alternate Designs
I considered not changing the version, however there are issues with versions of the JVM later than 8. I tested with OpenJDK 11 (11.0.2) which results in the error
which points to the error gradle/gradle#4503 and suggests upgrading the gradle version.
Possible Drawbacks
There is a possibility that newer gradle versions introduce different bugs but at present all tests run and gradle works fine when the project and gradle JDKs are set to 11
Release Notes
Upgrade gradle from 4.0.0 to 5.2.1